BLOCKING (shannon primary; carl light approved the model/conductor layer, which is nil-safe - the defect is in the view): app/views/releases/_deployment_average_chart.html.erb:25 - stages.dig(stage[:key], "average_seconds").to_i coerces a nil average to 0, and line 26's 2%-floor draws a colored bar, so the chart renders a false "Tested <1m" for every pre-migration release (all currently-shipped releases have nil Tested spans since tested_at is brand new). The pinned average rows and summary tiles on the same page correctly pass nil through release_duration_label and show an em-dash, so the dashboard contradicts itself on the exact surface this data-quality task exists to fix. FIX: keep nil (drop the .to_i coercion), render the em-dash, skip the bar for nil averages, and add one helper/component test covering the nil-average case. AT RESUBMIT: post bin/task note --resolves-feedback (PR #453 is not draft; no other gate work needed). CARRY AS NON-BLOCKERS: (1) merge-sequencing with PR #454 - both PRs insert helpers at the same application_helper.rb anchor after compact_stage_duration; whichever merges second conflicts, and resolution must keep this PR's precise_stage_duration body; (2) deployment_clock here near-duplicates #454's clock_12h - consolidation follow-up once both land; (3) reopen! keeps the first run's tested_at (consistent with keep-true-origin doctrine, noting only); (4) releases/show Stage Averages still reads legacy DurationCache and can disagree with the new table until migrated. Everything else verified clean: dor-check STALE cert was a confirmed false positive (branch tree equals recorded fingerprint e9e164569040b6c7e7f4fd57119d13ab9c0feba9), migration reversible, conductor wiring correct and rescue-guarded, tracker monotonic-safe, CI fully green. This is a one-line-plus-test rework; resubmit should be quick.

block on fix-deployment-duration-metrics · grade activity

BLOCKING (shannon primary; jasper light approved full-page paths): the live stream sources do not follow in-frame filter changes. app/views/agents/activities.html.erb:21 renders agents/activities_live_streams OUTSIDE turbo-frame#aa-activities-frame (frame opens ~line 37), while every filter control (sidebar session toggles, active-filter chips, Clear all, pager) is an in-frame link_to. Frame navigation swaps only frame children, so the initial-load turbo-cable-stream-source tags persist: (1) load unfiltered then click a session filter -> page stays subscribed to the global agents_activities stream and nonmatching payloads still append to the filtered table (acceptance 2 fails); (2) load ?sessions=sess-A then Clear all -> page stays session-only and the unfiltered table misses other sessions' live appends (acceptance 3 fails). The fix works only on full page loads, which is why current tests pass - they assert full-page render output. FIX: move the activities_live_streams render inside the top of the turbo-frame so stream sources swap with filtered content (Turbo connects/disconnects cable sources on insert/remove), and add a test asserting the sources render within turbo-frame#aa-activities-frame. AT RESUBMIT: run gh pr ready 452 (PR is still draft) and post bin/task note --resolves-feedback. NON-BLOCKING nits: empty filtered page renders hb-empty with no thead#aa-activities-head target so the first matching live activity cannot append (pre-existing, fix optional); extra agent_activity PK lookup per action broadcast is acceptable. What is good: dual-broadcast design (global + session streams, single-scope subscription) is sound, and green CI on head a34c0834 supersedes the local SIGTERM full-suite bypass - keep it.

block on filter-live-activities · grade activity

PR #12: ModelPage code is clean (Carl + Jasper both found no code defects; admin gate fails closed, no constantize leak, no XSS, route ordering correct) — but three gates block. (1) DoR is RED: no fingerprint-bound full-suite/rubocop cert recorded for this SHA — run bin/full-suite-check model-page-engine-protocol (or a justified [full-suite-bypass] note if bin/release-check is the canonical gem suite). (2) AC#6 unmet: mcritchie consumer CI is RED on AgentWorktreeTest#test_mcritchie_config_reserves_3020 (test/lib/agent_worktree_test.rb:53) — a pre-existing env-brittle test that shells to bin/agent-worktree and dies on 'repo missing: .../mcritchie-studio', unrelated to this diff; library-shape DoR requires BOTH consumer suites green, so guard that test to skip when the sibling mcritchie-studio checkout is absent, or get operator sign-off to except the flake and record a [consumer-ci-flake] note. (3) Re-point PR base from main to release (gh pr edit 12 --base release — same SHA 1671e54, zero drift) to avoid an accidental merge-to-main and keep qa-release-sweep semantics clean. Non-blocking for a follow-up: register-in-initializer guidance will empty the class-level @registry on Zeitwerk dev-reload (point hosts at config.to_prepare); and as_json dumps all columns (add an attribute filter before registering any sensitive model). No ModelPage code changes needed.

block on model-page-engine-protocol · grade activity

Code is merge-ready — all 5 acceptance criteria MET, CI green, Claude backward-compat preserved, docs accurate. The block is the DoR gate (evidence recording only, NOT a code rework). Two must-fix items: 1) MALFORMED full-suite/rubocop cert. checks_run has '[full-suite] ... green at 6fa63a721915' / '[rubocop] ... green at 6fa63a721915', but the gate (bin/lib/full_suite_gate.rb EVIDENCE_RE) only accepts the fingerprint INSIDE the brackets: [full-suite@6fa63a721915] / [rubocop@6fa63a721915]. dor-check reports both MISSING — confirmed run from the exact branch tree 6fa63a7219, so this is NOT a stale-cert false positive, the evidence line is unparseable. Fix: run 'bin/full-suite-check standardize-llm-logging' from the branch to stamp valid cert lines. 2) MISSING required tier tags. Backend shape requires [unit] + [integration] tagged checks_run lines; neither present (the tests exist and pass — recording only). Add them. NOTE: bin/task update --checks REPLACES the list, so re-include the valid cert lines AND the tier lines in one update. Fix opportunistically in the same pass (non-blockers, don't merit their own loop): 3) bin/atomic-capture-hook ~L844 outcome_for: a SUCCESSFUL Codex tool whose String output echoes 'Process exited with code N' (N!=0) is mis-flagged ERROR — tighten the match. 4) docs/agents/system/atomic-capture-hook.md polish: add the Codex string-based 'Process exited with code N' signal to the outcome-field row (~:51); mention the new provider-adapter/Codex-normalization/transcript-recovery unit tests in the Tests section (~:291). After re-cert, dor-check will pass — resubmit and post a note --resolves-feedback.

block on standardize-llm-logging · grade activity

pr-review blocked review: carl: request-changes - Code matches countdown acceptance, but the merge gate is not satisfied.; shannon: merge-ready - Follow-up light UI read found no blockers; prior overrun contrast issue is fixed.

block on release-stage-countdown · grade activity

Coupled-pair doc/code divergence (Carl primary: REQUEST-CHANGES; Jasper light flagged the same as a coherence nit). The policy tells agents to record findings with 'bin/agent-activity action --summary "…"' WITHOUT the --finding flag (docs/agents/modules/result-distillation.md — the validate->resolve->finding example ~:38, the grain table ~:58, and the 'How to record a finding' section). But the coupled PR #431 ships a bare --finding verb (FINDING_KIND="finding" in bin/atomic-event) whose entire purpose is to render 'FINDING · <conclusion>' / kind=finding rows and keep distilled findings queryable as one class; without --finding an 'action' defaults to kind=bash. So an agent following this doc verbatim produces kind=bash rows, not the finding rows #431 exists to create — the governing policy never instructs the flag its coupled code adds. FIX: add --finding to the command examples (:38, :58, and 'How to record a finding'). ALSO tighten the paging phrasing at ~:46 ('reopening a file only to see the next chunk') to something like 'reopening its own spilled tool-output file' — #431 suppresses ONLY re-reads under a tool-results/ dir and explicitly KEEPS real-source-file paging, so the current wording can read as claiming all chunk-paging is dropped. All 3 acceptance criteria otherwise PASS and CI is green — this is a light, trivial doc fix to make the pair consistent; resubmit after and post a note --resolves-feedback.

block on result-distillation-policy · grade activity

Re-review of PR #425 (resubmission). RESOLVED: the doc-drift block is cleared — docs/agents/system/atomic-capture-hook.md's summary row now matches the code line-for-line (Carl confirmed against synthesize_summary + redact_secrets at head 699a00ed), the only remaining 'Bash only' is on the key_method row which is correct, and there is ZERO code delta since last approval (only the doc commit). CI is GREEN (test SUCCESS, mergeState CLEAN). ONE remaining gate issue blocks reviewed: the full-suite + rubocop cert is STALE. It was recorded against 5cba403d (fingerprint 60a96b80) but the doc commit 699a00ed landed on top, so the cert no longer binds to head — the 'certify after final commit' trap. bin/dor-check REFUSES submitted->reviewed until a fresh cert binds to head, and it does NOT self-heal by waiting. FIX (no code work): from your worktree re-run 'bin/full-suite-check label-non-bash-capture-actions' as the LAST step (commit nothing after it), then push, 'bin/task move label-non-bash-capture-actions submitted', and post 'bin/task note label-non-bash-capture-actions --resolves-feedback ...'. Since CI is already green and the only delta is the doc, a clean re-cert clears the gate on the next pass with no further changes.

block on label-non-bash-capture-actions · grade activity

Doc drift on the capture-hook's OWN contract: docs/agents/system/atomic-capture-hook.md line 33 still states 'summary — Bash only … other tools ⇒ absent', which is the exact behavior this PR reverses. Since non-Bash tools now synthesize a summary (Read/Edit/Write/NotebookEdit→basename, Grep/Glob→pattern, Task/Agent→description, WebFetch→url, WebSearch→query, AskUserQuestion→header), that payload-contract row is now false and will mislead future agents. Fix: in the same pass, update line 33 (and any nearby 'Bash only' summary phrasing) to describe the synthesized non-Bash label and note it is pattern-redacted like input/key_method; Bash stays its description-derived summary. Code, tests, secret-redaction (action_summary → redact_secrets before POST), nil-safety, and Bash passthrough all verified clean and CI-green — only the doc must catch up. Re-submit after the doc fix.

block on label-non-bash-capture-actions · grade activity

Both reviewers (Shannon primary + Jasper light) APPROVE the code — this is a re-certification, NOT code rework. bin/dor-check is RED: the [full-suite]/[rubocop] certs are fingerprint-bound to tree bce53762, but the PR head is 92562a57 after #413/#414 merged into release beneath this PR (pure rebase artifact — the +74/-46 helper diff is byte-identical and GitHub CI is green on the head). No code change needed. Re-bind the cert to the current head in ONE shot: run bin/full-suite-check keep-mascot-off-deploy-cards then bin/dor-check keep-mascot-off-deploy-cards back-to-back (same root, so the cert is not stale between them), then move submitted and resubmit.

block on keep-mascot-off-deploy-cards · grade activity

pr-review request-changes (both reviewers). (1) Gem release_check is unregistered/unwrapped in the release telemetry — register and wrap it. (2) qa_smoke can mark Live on QA before the blocking post-deploy hook aborts — gate the Live stamp behind the post-deploy hook so a hook abort blocks Live. Focused release-CLI suite is green under Ruby 3.3; extend coverage to these paths, then resubmit and post a note that resolves this feedback.

block on test-scope-telemetry-registry · grade activity

pr-review blocked review: carl: request-changes - Request changes: release telemetry misses gem release_check and qa_smoke can mark Live on QA before a blocking post-deploy hook aborts.; alex: request-changes - Request changes: gem release_check remains unregistered/unwrapped; focused release CLI suite is green under Ruby 3.3.

block on test-scope-telemetry-registry · grade activity

Code is APPROVED by both reviewers (Carl primary + Shannon light): weighting logic correct, both mascot seams route through the weighted bag, N+1 claim verified, tests assert 2x/1x non-flakily, draw_from_slugs left unweighted. One required reconciliation before you can advance: sibling #403 reclassify-togepi-and-tyrogue (reviewed, merging FIRST via the qa-release sweep) drops the spawn deck base count 131->129. So your hardcoded assertions in test/models/pokemon_test.rb must become: assert_equal 131 -> assert_equal 129 (base) and assert_equal 155 -> assert_equal 153 (weighted bag = 129 + 24). Keep assert_equal 24 (three-stage) AS-IS — Togepi->Togetic and Tyrogue->Hitmons are both 2-stage lines (Togekiss is out-of-range), so the three-stage count is unchanged. Steps: after #403 lands on release, rebase this branch onto origin/release, apply that 2-line count fix, re-run CI, resubmit. NOTE: your earlier CI 'test' red was NOT your diff — it was the FLAKY system straggler test/system/review_events_test.rb (ReviewEventsTest deployment-link-menu), which passed green on #403's run of the byte-identical test; your branch is 0-behind release and touches only pokemon.rb + 2 model tests. A fresh CI run after rebase should clear it.

block on weight-three-stage-mascot-draws · grade activity

pr-review blocked review: carl: request-changes - Blocker found: the CI gate checks statuses but does not verify that the PR is open, so a closed PR with green historical checks can pass as GitHub CI green.; jasper: merge-ready - Light review: CI gate implementation matches acceptance; live PR CI is green and dor-check is ready.

block on gate-dor-check-on-github-ci · grade activity

pr-review blocked review: shannon: merge-ready - No blockers found. PR #391 matches the third-evolution timeline and board acceptance criteria and is clean to merge into release.; jasper: request-changes - Request changes: happy path and CI are green, but third_evolution false-positives on skipped submit gate.

block on surface-third-evolution-moment · grade activity

pr-review blocked review: shannon: request-changes - current PR head 29f46ea2 is not merge-ready because GitHub CI test is red; test/system/task_timeline_mascot_history_test.rb:70 still expects Charizard as a normal timeline crew member after this PR moves that face into the Evolve reel.

block on surface-third-evolution-moment · grade activity

Code + tests are correct and CI-green — the segment-aware droppable? (cd&&work KEPT, all-overhead DROPPED), the open-span marker written on start AND next (both route through start(), so no stale-id leak across boundary rolls), the nil->compact->server-derived fallback (atomic_action.rb:155), and the non-fatal rescue paths all check out; approving the fix on its merits. ONE rework item, doc-only and it must ride with this change: the PR changes the capture drop rule from first-token to PER-SEGMENT, but the canonical hook doc docs/agents/system/atomic-capture-hook.md:86-95 still documents the OLD rule and states 'cd ... && bin/atomic-event drops as navigation (first token cd)' -- which now actively re-teaches the exact bug this PR fixes (an agent reads it and believes cd&&work still drops). Update that 'What it DROPS' section: a call drops only when EVERY shell segment is navigation (cd/pushd/popd/pwd) OR narration (a bin/atomic-event invocation), so 'cd X && git commit' is CAPTURED; fix the now-wrong first-token reasoning on the cd&&bin/atomic-event example. Then re-cert from the same worktree root and re-push. Nothing else needed.

block on deterministic-session-action-capture · grade activity

Stacked on base PR #383 (base-level-spawn-pool), now reviewed. Reviewers (carl+shannon) found evolution-gates code/tests green and acceptance met — the only hold is sequencing: #385 depends on #383's bin/rails pokemon:seed post-deploy backfill and shares roster files with #384. After #383 merges to release, rebase feat/task-mascot-evolution-gates onto release, confirm CI green and the seed ordering, and resubmit.

block on task-mascot-evolution-gates · grade activity

Stacked on base PR #383 (base-level-spawn-pool), now reviewed and riding the next qa-release sweep. Reviewers (shannon+alex) found the roster shiny/evolution UI green and acceptance-complete — the only hold is sequencing: #384's branch carries #383's migration/data-model commit, so it must not be swept before #383 lands. After #383 merges to release, rebase feat/pokemon-roster-shiny-evolutions onto release (dropping #383's commits), confirm CI green, and resubmit.

block on pokemon-roster-shiny-evolutions · grade activity

Avi Heartbeat blocked review: carl: request-changes - Request changes: direct bin/dor-check crashes before the new fingerprint-delta verdict unless run under Ruby 3.3.11; targeted logic passes under the intended Ruby.; alex: merge-ready - Light review found no blockers. DevOps gate behavior matches acceptance, DoR and CI are green, targeted tests and RuboCop pass under Ruby 3.3.11, and dry merge into current origin/release is conflict-free.

Avi Heartbeat blocked review: carl: merge-ready - Primary review found the DevOps gate hardening ready: acceptance covered, CI and DoR green, targeted local checks pass, and merge safety is clean.; alex: request-changes - Light review found one blocking ship-preflight auto-clean safety gap; CI, focused tests, and dor-check are green otherwise.

Two blockers. (1) Auto-clean data-loss gap: autocleanable? proves the dirty FILES are on origin/release but never checks the local main TIP — a primary with an unpushed local commit plus the routine release-identical merge noise passes all four facts, and autoclean_primary!'s git reset --hard origin/main silently orphans the unpushed commit (before this PR that state aborted loudly). Fix: gather head_at_origin_main in reconcile_offender (git merge-base --is-ancestor HEAD origin/main), require it in autocleanable?, and add the ahead-main + release-identical-dirt REFUSED case to the real-git adversarial matrix in test/lib/release_cli_test.rb (with_primary_repo never starts ahead, so the matrix misses it). Also fix the self-contradicting file_on_release? comment ('an untracked-but-identical file reconciles' is false — the code correctly refuses all untracked). (2) Rebase on origin/release: PR #352 landed the same board_cleared_block.spec.js untag with different comment wording, so #361 is CONFLICTING against the updated base. After both: re-certify — cert goes STALE on any post-cert commit, and your own new dirty-tree guard enforces commit-then-cert order.

Avi Heartbeat blocked review: carl: request-changes - Code path and targeted checks look sound, but PR #371 is not merge-safe against current origin/release.; shannon: request-changes - Light review found the stage-stamp implementation aligned with acceptance and focused local checks green, but PR #371 is currently unmergeable against origin/release; resolve the production-deploy SOP conflict before Avi/Carl can clear it.

block on release-stage-timestamp-handoff · grade activity

Avi Heartbeat blocked review: shannon: request-changes - Implementation matches the shiny mascot acceptance criteria and checks are green, but PR #370 is draft and not mergeable: current origin/release conflicts in db/schema.rb, so the branch needs a rebase/schema regeneration before Avi can advance it.; carl: request-changes - Light review found the shiny mascot implementation and data coverage sound, but PR #370 is not merge-safe until the draft/conflict/migration-lane issues are corrected.

block on shiny-pokemon-mascot-avatars · grade activity