Created
Jun 26, 06:24
Started
Jun 26, 16:33
Completed
Jun 26, 18:05
DevOps handoff
Type
Chore
Shape
backend
Worktree Slug
docs-gate-cleanup
Repositories
mcritchie-studio
Release Train
—
Branch
feat/docs-gate-cleanup
Local URL
—
QA URL
—
Production URL
—
Acceptance Criteria
Expected Test Plan
Checks Run
Stage Timeline
Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. — means the agent didn't report that metric.
Conversation
QA review feedback, agent handoffs, and follow-up notes for this task.
PR #232 is ready for Avi review. Changes align active agent docs with designed/building/submitted/reviewed/assembled/shipped, make QA-release stop at the production ship gate, add legacy-stage hints in bin/task, update devops-cycle to live stages, make install-agent-docs worktree-safe for global hooks, remove filter_map from command-line Ruby scripts, and sync generated AGENTS/CLAUDE/global skills locally. Verification: targeted unit/integration tests, bin/install-agent-docs check, bin/agent-worktree doctor no Ruby 2.6 crash, bin/full-suite-check green at f43146115358, bin/dor-check green.
PR #232 still leaves live docs/tooling vocabulary inconsistent. Update docs/topics/data-model.md and docs/topics/theme.md to the live stage/readiness names, and replace QA acceptance / production-ready lane wording in docs/agents/modules/devops-task-board.md and docs/agents/modules/parallel-agent-devops.md with Ready To Assemble / Assembled Release. Re-run focused docs/tooling checks and CI before re-review.
PR #232 now conflicts with the updated release branch after the current QA train. Resolve release conflicts in docs/agents/skills/qa-release/SKILL.md and test/commands/install_agent_skills_test.rb, update the branch on top of origin/release, and re-run focused checks plus CI before re-review. GitHub also showed no completed workflow runs at current head 4f0e665.
Heavy (Carl): APPROVE — gates/CLI/installer correct; re-ran all tiers green on head 83c8d9d. Light (Alex/docs): BLOCK — acceptance #2 'Active docs use live stage names' not fully met; three active docs still carry legacy stages/dead endpoints, contradicting this PR's own corrections elsewhere. FIX: (1) docs/agents/system/comms.md lines 7-12 still document GET /api/v1/tasks?stage=queued + POST /api/v1/tasks/:slug/{start,complete,fail_task} — none exist (routes.rb:223-230 = index/show/create/update/destroy + member POST :intent only); rewrite to PATCH /api/v1/tasks/:slug + POST .../intent. (2) docs/topics/routes-and-controllers.md:93 still lists POST .../{queue,start,complete,fail_task} — mirror the architecture.md fix. (3) docs/agents/agents/mack/role.md:25 uses legacy 'queued' stage — use 'designed'. (4) config/feature_shapes.yml:8 points at docs/agents/system/devops-cycle.md (§3) which does not exist — should be devops-cycle-design.md (§3). Also: branch tip 83c8d9d is a 'Merge release into docs gate cleanup' commit past the certified checks SHA d13600a — re-run + re-stamp full-suite/rubocop on the rebased tip. NOTE: this PR owns the qa-release SKILL.md operator-gated flip that #235's §1.4 rewrite depends on — co-land the two.
APPROVED ON THE MERITS (Carl heavy + Alex light, both green) — all 4 stale-doc items are fixed (comms.md, routes-and-controllers.md, mack/role.md, feature_shapes.yml:8). This is a MERGE-SEQUENCING REBASE, not a quality block. Sibling PR #235 (release-autonomy-cleanup) is landing THIS release and now owns the operator-gated ship rewrite in both docs/agents/skills/qa-release/SKILL.md (your edit is byte-identical → no-op) and docs/agents/system/devops-cycle-design.md §1.3+§1.4 — backed by the REAL config/release_builder.yml + Release::BuilderPolicy that #235 ships. Your devops-cycle-design.md edits to the same §1.3 'RC assembly autonomy' paragraph + §1.4 (chip line, auto-ship callout, --yes bullets, step 6) now CONFLICT, and your 'Until it is backed by a checked-in config/release_builder.yml, treat this section as canonical' framing is stale (the config now exists). REBASE RECIPE: rebase feat/docs-gate-cleanup onto origin/release (post-#235); in devops-cycle-design.md TAKE release's (=#235's) config-backed §1.3/§1.4 paragraphs and re-apply ONLY your unique 'Claude->agent session' rename + any non-overlapping vocab; drop the 'until a config lands' paragraph (the old 'prepare silently no-ops' line is also superseded by #235's 'prepare aborts without confirmation in a non-interactive shell'). SKILL.md needs no action. Keep all your other ~33-file vocab fixes. Re-stamp checks + re-submit; it merges clean next run.
Sealed-bid sizing
Edit →Alex (PM)
—
Avi (PO)
—
Dev
MEDIUM
Actual
XL
We emailed a one-tap sign-in link to . It expires shortly and can only be used once.
No email? Check spam, or close this and try again.