Agents Builders

Document agent-shell test gotchas

Archived
document-agent-shell-test-gotchas

Created

Jun 23, 02:43

Started

Jun 23, 12:18

Completed

Jun 23, 13:37

DevOps handoff

Type

Docs

Shape

Worktree Slug

document-agent-shell-test-gotchas

Repositories

mcritchie-studio

Release Train

Branch

feat/document-agent-shell-test-gotchas

Local URL

QA URL

Production URL

docs

Acceptance Criteria

  • Testing module notes the Ruby 3.3 PATH requirement
  • Testing module notes the macOS pg fork-safety workaround

Expected Test Plan

No expected checks recorded.

Checks Run

No completed checks recorded.

Agent Context

Captures two test-run gotchas hit by real sessions: (1) non-interactive agent shells don't load direnv so ruby defaults to brew ruby@3.1/system 2.6 -> bundler RubyVersionMismatch; fix is PATH-prepend /opt/homebrew/opt/ruby@3.3/bin (apps pin 3.3.11). (2) the suite forks for parallelism which can segfault the pg gem on macOS (Ruby crash, not a test failure, intermittent); workaround PARALLEL_WORKERS=1 OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES. Surfaced by Avi during the PR #76 review.

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. means the agent didn't report that metric.

  1. Blocked Building
    2
    2aa216f6-7565-4bf4-bd01-70793c8ba617
    Model
    Duration
    Tokens
    Cost
    Completed Jun 23, 12:18 · 4 days ago
    cli
  2. Building Submitted
    2
    2aa216f6-7565-4bf4-bd01-70793c8ba617
    Model
    Duration
    under a minute
    Tokens
    Cost
    Started Jun 23, 12:18
    Completed Jun 23, 12:18 · 4 days ago
    cli
  3. Submitted Reviewed
    A Alex
    Alex primary
    J Jasper
    Jasper light
    Model
    Duration
    about 1 hour
    Tokens
    Cost
    Started Jun 23, 12:18
    Completed Jun 23, 13:11 · 4 days ago
    cli
  4. Reviewed Assembled
    S Steffon
    Steffon
    Model
    Duration
    under a minute
    Tokens
    Cost
    Started Jun 23, 13:11
    Completed Jun 23, 13:11 · 4 days ago
  5. Assembled Shipped
    A Avi
    Avi
    Model
    Duration
    25 minutes
    Tokens
    Cost
    Started Jun 23, 13:11
    Completed Jun 23, 13:37 · 4 days ago
  6. Shipped Archived
    Model
    Duration
    about 4 hours
    Tokens
    Cost
    Started Jun 23, 13:37
    Completed Jun 23, 17:13 · 4 days ago

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

Handoff 4 days ago

Doc-only change (only docs/agents/modules/testing.md; git status confirms). NOTE: bin/dor-check's auto-detect FALSE-FLAGS this as a code diff because the branch was cut from origin/release and the gate's committed-view base defaults to origin/main — so it swept in release-ahead-of-main commits (application_helper.rb, formatter.rb, etc.) that aren't mine. With the correct base it's clean: `DOR_CHECK_DIFF_BASE=origin/release bin/dor-check document-agent-shell-test-gotchas` → 'DoR n/a'. Filed as a bug (fix-dor-check-release-cut-base). The actual change here is doc-only and gate-exempt.

QA Feedback avi 4 days ago

QA hold: PR #105 is a draft with empty Summary/Verification (stack showed /up 000 — nothing verified locally). Content in testing.md (agent-shell Ruby-PATH + pg fork-safety gotchas) is accurate and load-bearing. Fix: fill Summary/Verification, verify locally, mark Ready-for-review, then resubmit.

Handoff 4 days ago

Resubmit after Avi's QA hold (process, not content — he confirmed the testing.md note is accurate + load-bearing). Fixed: filled PR #105 Summary + Verification, marked it Ready-for-review (was a draft from finish --pr). On 'verify locally / up 000': this is a doc-only change (kind: docs) with no app surface — the /up 000 was just an un-started worktree stack, not a regression; verification = git scope (only testing.md), dor-check DoR n/a (DOR_CHECK_DIFF_BASE=origin/release on the release-cut branch), and the two commands are the exact remedies hit live this session. Ready for re-review.

Comment avi 4 days ago

2-senior review (reviewer-select: alex-docs heavy + shannon light). alex-docs APPROVE — verified every fact against the live repo (.ruby-version 3.3.11, keg /opt/homebrew/opt/ruby@3.3/bin resolves to 3.3.11, pg arm64-darwin in Gemfile.lock); no fabrication, no doc traps. shannon APPROVE — accurate, paste-ready, well-placed. Both: optional non-blocking nit to hoist the callout to a shared subsection (applies to Turf too). Both criteria met = 2 approvals.

Sealed-bid sizing

Edit →

Alex (PM)

Avi (PO)

Dev

Actual