McRitchie Studio
Say Hi 👋
Agents Builders
← All Tasks
Sizing

Exclude builder from reviewers

Archived
exclude-builder-from-reviewers

Created

Jun 23, 15:19

Started

Jun 23, 21:25

Completed

Jun 24, 00:16

DevOps handoff

Type

Feature

Shape

backend

Worktree Slug

exclude-builder-from-reviewers

Repositories

mcritchie-studio

Release Train

—

Branch

feat/exclude-builder-from-reviewers

Pull Request

https://github.com/amcritchie/mcritchie-studio/pull/136

Local URL

—

QA URL

—

Production URL

—

tooling devops

Acceptance Criteria

  • reviewer-select excludes the task's builder from the pool
  • Build records builder identity on the task
  • Degrades to domain-only pick when builder unknown

Expected Test Plan

  • unit
  • integration

Checks Run

  • [unit] reviewer_selector: non-pool builder excludes nobody + not-a-candidate log
  • [unit] task: soul-slug stamped, session-UUID not stamped, no-actor preserves built_by
  • [integration] end-to-end soul actor real exclusion; UUID actor no false exclusion
  • [suite] bin/rails test 1304 runs 0 fail 0 err 4 skip; bin/rubocop 464 files clean

Agent Context

Rework of Carl HEAVY findings on PR #136. builder_excluded? now gates on pool membership (+builder_candidate?); stamp_builder resolves built_by to a SOUL_SLUG so a bare CLI build move (session UUID actor) no longer writes a bogus builder — degrades truthfully to domain-only. builder_log_token gains not-a-candidate. Doc updated (devops-cycle-design.md:247). Rebased onto origin/release (#133/#134). Full suite + full rubocop green.

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. — means the agent didn't report that metric.

  1. Created → Designed
    R Rattata
    Rattata
    Model
    —
    Duration
    —
    Tokens
    —
    Cost
    —
    Completed Jun 23, 15:19 · 4 days ago
    api
  2. Designed → Building
    R Rattata
    Rattata
    Model
    claude-opus-4-8
    Duration
    about 6 hours
    Tokens
    —
    Cost
    —
    Started Jun 23, 15:19
    Completed Jun 23, 21:04 · 4 days ago
    cli
  3. Building → Submitted
    R Rattata
    Rattata
    Model
    claude-opus-4-8
    Duration
    9 minutes
    Tokens
    7,636,512
    Cost
    ~$5.04
    Started Jun 23, 21:04
    Completed Jun 23, 21:13 · 4 days ago
    cli
  4. Submitted → Building
    R Rattata
    Rattata
    Model
    claude-opus-4-8
    Duration
    12 minutes
    Tokens
    8,967,510
    Cost
    ~$6.65
    Started Jun 23, 21:13
    Completed Jun 23, 21:25 · 4 days ago
    cli
  5. Building → Submitted
    R Rattata
    Rattata
    Model
    claude-opus-4-8
    Duration
    9 minutes
    Tokens
    —
    Cost
    —
    Started Jun 23, 21:25
    Completed Jun 23, 21:34 · 4 days ago
    cli
  6. Submitted → Reviewed
    C Carl
    Carl primary
    S Shannon
    Shannon light
    Model
    claude-opus-4-8
    Duration
    9 minutes
    Tokens
    —
    Cost
    —
    Started Jun 23, 21:34
    Completed Jun 23, 21:43 · 4 days ago
    cli
  7. Reviewed → Assembled
    S Steffon
    Steffon
    Model
    —
    Duration
    9 minutes
    Tokens
    —
    Cost
    —
    Started Jun 23, 21:43
    Completed Jun 23, 21:53 · 3 days ago
  8. Assembled → Shipped
    A Avi
    Avi
    Model
    —
    Duration
    about 2 hours
    Tokens
    —
    Cost
    —
    Started Jun 23, 21:53
    Completed Jun 24, 00:16 · 3 days ago
  9. Shipped → Archived
    —
    Model
    —
    Duration
    about 3 hours
    Tokens
    —
    Cost
    —
    Started Jun 24, 00:16
    Completed Jun 24, 03:44 · 3 days ago

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

QA Feedback avi 4 days ago

Rework RE-REVIEW PASS: carl (HEAVY) approve — all resolved: builder_candidate? membership gate (no phantom exclusion); SOUL_SLUG gate so a UUID actor degrades to domain-only (a real session id passing the regex is ~4e-14 and benign); CI lint green; docs/test/log-token done; FULL suite 1304/0 + rubocop 0 offenses on head bf08184. jasper (LIGHT) approve. DEFERRED non-blocking (jasper): bin/reviewer-select excluded_line prints 'KEPT: too few' for a known non-pool builder where it should say 'not a candidate' (Rails log already correct) — small CLI follow-up. MERGE COORDINATION: #135 must rebase onto this and fold the excluded builder into seed_for's key. HELD at reviewed (not merged) so it does not contaminate the pending 4-fix prod ship; merges into the follow-up train after the current release ships.

Sealed-bid sizing

Edit →

Alex (PM)

—

Avi (PO)

—

Dev

—

Actual

—