McRitchie Studio
Say Hi 👋
Agents Builders
← All Tasks
Sizing

Fix qa-intake merge signal

Archived
fix-qa-intake-merge-signal

Created

Jun 23, 18:36

Started

Jun 23, 18:38

Completed

Jun 23, 19:57

DevOps handoff

Type

Bug

Shape

backend

Worktree Slug

fix-qa-intake-merge-signal

Repositories

mcritchie-studio

Release Train

—

Branch

feat/fix-qa-intake-merge-signal

Pull Request

https://github.com/amcritchie/mcritchie-studio/pull/131

Local URL

—

QA URL

—

Production URL

—

tooling devops

Acceptance Criteria

  • qa-intake trusts GitHub mergeStateStatus over local staleness
  • clean mergeable PR not flagged needs-agent for staleness
  • behind-but-clean shown as informational note only

Expected Test Plan

  • unit

Checks Run

  • [unit] clean+mergeable+green PR behind origin/release classifies avi-ready, not needs-agent
  • [unit] clean PR behind base yields an Avi-review action, not return-to-agent
  • [unit] behind-base staleness downgraded to an informational note when merge is clean
  • [unit] genuine blockers preserved: dirty worktree, GitHub BEHIND, conflicting PR still needs-agent
  • [integration] bin/qa-intake --json queues a clean behind-base PR as avi-ready with an info note (fake gh + registry)
  • [integration] full test/commands suite green (40 runs, incl. existing qa-intake pipeline test)

Agent Context

Bug: qa-intake emits [needs-agent] action=return-to-feature for PRs that are merely N commits behind origin/release, even when GitHub reports mergeable=MERGEABLE and mergeStateStatus=CLEAN with green CI. Observed 2026-06-23 on PR #124 and #125 (both clean+green, both wrongly flagged). Fix: when GH says CLEAN/MERGEABLE+CI green, do not emit needs-agent for pure staleness; downgrade to an informational note at most. Write failing regression test FIRST.

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. — means the agent didn't report that metric.

  1. Created → Designed
    Z Zapdos
    Zapdos
    Model
    —
    Duration
    —
    Tokens
    —
    Cost
    —
    Completed Jun 23, 18:36 · 4 days ago
    api
  2. Designed → Building
    Z Zapdos
    Zapdos
    Model
    claude-opus-4-8
    Duration
    2 minutes
    Tokens
    —
    Cost
    —
    Started Jun 23, 18:36
    Completed Jun 23, 18:38 · 4 days ago
    cli
  3. Building → Submitted
    Z Zapdos
    Zapdos
    Model
    claude-opus-4-8
    Duration
    14 minutes
    Tokens
    1,669,870
    Cost
    ~$2.50
    Started Jun 23, 18:38
    Completed Jun 23, 18:52 · 4 days ago
    cli
  4. Submitted → Reviewed
    C Carl
    Carl primary
    S Shannon
    Shannon light
    Model
    claude-opus-4-8
    Duration
    19 minutes
    Tokens
    —
    Cost
    —
    Started Jun 23, 18:52
    Completed Jun 23, 19:11 · 4 days ago
    cli
  5. Reviewed → Assembled
    S Steffon
    Steffon
    Model
    —
    Duration
    2 minutes
    Tokens
    —
    Cost
    —
    Started Jun 23, 19:11
    Completed Jun 23, 19:13 · 4 days ago
  6. Assembled → Shipped
    A Avi
    Avi
    Model
    —
    Duration
    44 minutes
    Tokens
    —
    Cost
    —
    Started Jun 23, 19:13
    Completed Jun 23, 19:57 · 4 days ago
  7. Shipped → Archived
    —
    Model
    —
    Duration
    about 8 hours
    Tokens
    —
    Cost
    —
    Started Jun 23, 19:57
    Completed Jun 24, 03:44 · 3 days ago

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

QA Feedback avi 4 days ago

2-senior PASS: carl (HEAVY) approve — verified failing-first by reverting (4 bug tests RED, 4 preservation GREEN); fix keys on mergeStateStatus CLEAN/HAS_HOOKS, GitHub genuine BEHIND still flagged, all other needs-agent triggers preserved. shannon (LIGHT) approve. Deferred follow-ups: separate 'Worktree Attention' view still nags rebase for clean+behind worktrees; add HAS_HOOKS + conflicting-not-behind test cases.

Sealed-bid sizing

Edit →

Alex (PM)

—

Avi (PO)

—

Dev

—

Actual

—