McRitchie Studio
Say Hi 👋
Agents Builders
← All Tasks
Sizing

Guard release unreviewed merges

Archived
guard-release-unreviewed-merges

Created

Jun 25, 05:39

Started

Jun 25, 05:49

Completed

Jun 25, 14:24

DevOps handoff

Type

Feature

Shape

backend

Worktree Slug

guard-release-unreviewed-merges

Repositories

mcritchie-studio

Release Train

—

Branch

feat/guard-release-unreviewed-merges

Pull Request

https://github.com/amcritchie/mcritchie-studio/pull/189

Local URL

http://localhost:3033

QA URL

—

Production URL

—

devops release-safety

Acceptance Criteria

  • bin/release merge refuses tasks not yet reviewed
  • Merge requires task in reviewed stage first
  • Explicit override flag logs a recorded bypass
  • Direct unreviewed release-branch merges are flagged

Expected Test Plan

  • unit
  • integration

Checks Run

  • [review] Carl (heavy/backend) + Jasper (light) APPROVE_WITH_NITS — all 4 met; enforce_review_gate! aborts before gh pr merge; BATCH regression PASS (one blocked slug aborts batch, override threads review_bypassed spine event per unreviewed member, ensure-reset no leak). MINOR: screen_merge safe-set is reviewed-only but adopt! no-ops reviewed+assembled → re-run incl. assembled member misleadingly blocked; mirror adopt! safe-set

Agent Context

Source: devops retro retro-rel-20260623-fb969a.md line 59 ('guard release against unreviewed direct merges, or auto-verify them') and line 54 — an unreviewed PR (#138) was merged straight into release during the scheduled wait; verify-post-merge later caught a drag bug it introduced. Goal: bin/release merge (the step that flips a task to assembled) must REFUSE a PR whose task is not in the reviewed stage, unless an explicit --override is passed (which records a bypass on the TaskEvent paper trail). Optionally auto-verify (run the suite) on an unreviewed merge instead of hard-refusing. Closes the gap where the review gate can be skipped by merging directly. Originated as a local dev-fixture card on the board.

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. — means the agent didn't report that metric.

  1. Created → Designed
    Z Zapdos
    Zapdos
    Model
    —
    Duration
    —
    Tokens
    —
    Cost
    —
    Completed Jun 25, 05:39 · 2 days ago
    api
  2. Designed → Building
    Z Zapdos
    Zapdos
    Model
    claude-opus-4-8
    Duration
    11 minutes
    Tokens
    —
    Cost
    —
    Started Jun 25, 05:39
    Completed Jun 25, 05:49 · 2 days ago
    cli
  3. Building → Submitted
    Z Zapdos
    Zapdos
    Model
    claude-opus-4-8
    Duration
    12 minutes
    Tokens
    196,686
    Cost
    ~$0.15
    Started Jun 25, 05:49
    Completed Jun 25, 06:01 · 2 days ago
    cli
  4. Submitted → Reviewed
    C Carl
    Carl primary
    J Jasper
    Jasper light
    Model
    claude-opus-4-8
    Duration
    about 7 hours
    Tokens
    —
    Cost
    —
    Started Jun 25, 06:01
    Completed Jun 25, 12:31 · 2 days ago
    cli
  5. Reviewed → Assembled
    S Steffon
    Steffon
    Model
    —
    Duration
    about 2 hours
    Tokens
    —
    Cost
    —
    Started Jun 25, 12:31
    Completed Jun 25, 14:04 · 2 days ago
  6. Assembled → Shipped
    A Avi
    Avi
    Model
    —
    Duration
    20 minutes
    Tokens
    —
    Cost
    —
    Started Jun 25, 14:04
    Completed Jun 25, 14:24 · 2 days ago
  7. Shipped → Archived
    8
    81fad33e-98b5-4075-8ed6-d0efe6cb5804
    Model
    claude-opus-4-8
    Duration
    about 7 hours
    Tokens
    —
    Cost
    —
    Started Jun 25, 14:24
    Completed Jun 25, 21:16 · 1 day ago
    cli

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

No task feedback has been recorded yet.

Sealed-bid sizing

Edit →

Alex (PM)

—

Avi (PO)

—

Dev

—

Actual

—