Agents Builders

Primary owns review lane

Shipped carl
primary-owns-review-lane

Created

Jun 26, 22:38

Started

Jun 27, 05:43

Completed

Jun 27, 06:52

DevOps handoff

Type

Feature

Shape

ui-only

Worktree Slug

primary-owns-review-lane

Repositories

mcritchie-studio

Release Train

Branch

feat/primary-owns-review-lane

QA URL

Production URL

devops,agent-ops

Acceptance Criteria

  • Conductor spawns the primary reviewer sub-agent with goals
  • Primary spawns the light reviewer as sub-agent
  • Primary drives to reviewed and owns the merge
  • Both reviews pass with no blocker continues

Expected Test Plan

  • [component] /stages + /stages/sop render the nested review chain; SOP infographic shows zero divergence markers
  • [manual] eyeball /stages/sop infographic + /stages Deploy guide on the QA candidate

Checks Run

  • [static] review_lane_docs_test: review docs say primary spawns light + primary runs bin/release merge; no conductor-merge
  • [unit] devops/vocabulary_test: no SOP step diverges; Release Branch names primary + bin/release merge
  • [component] tasks_controller sop test: /stages/sop renders zero divergence markers
  • [component] tasks_controller stages test: /stages guide shows nested review chain (two senior reviewers, primary owns merge)
  • [full-suite@b42cc404b1cd28b4c575fb053ca4566afc69a5b0] bin/rails test green
  • [rubocop@b42cc404b1cd28b4c575fb053ca4566afc69a5b0] bin/rubocop clean

Agent Context

Adopted 2026-06-26 (operator). Re-home the review lane so the PRIMARY reviewer owns it end-to-end via NESTED sub-agents (replaces the flat peer-spawn of avi + 2 seniors). FLOW with Avi placement DECIDED = Option B (2026-06-26): (1) Conductor -> AVI as a THIN delegation pre-step: Avi confirms the PR is acceptance-worthy (product/PO lens) AND picks the primary+light pair via reviewer-select. (2) Hand off to the PRIMARY as a sub-agent with ALL the technical-review goals: deep review of diff-vs-acceptance + code standards + smell + scalability, confirm base tiers green, drive-to-reviewed, and OWN the merge into release. (3) The PRIMARY spawns the LIGHT reviewer as ITS OWN sub-agent, so the primary holds full context when the light verdict returns. (4) Both complete and NEITHER flags a blocker -> the primary moves the task to reviewed and runs the merge into release (today the conductor runs bin/release merge; this gives the primary that responsibility). Option B keeps product-acceptance (Avi/PO) DISTINCT from technical review (the senior), preserving the PO lens and 'acceptance checked twice'. Roles sourced from config/devops_vocabulary.yml reviewer_roles (primary/light). DEPENDS ON reviewer-roles-primary-light landing first. This resolves the 'primary owns the merge' divergence the SOP flags on the Release Branch node; the Main Branch divergence was resolved as a no-op (it is the merge-forward guard).

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. means the agent didn't report that metric.

Sizing Avi · PO LARGE Dev LARGE Actual XL ≠ forecast
  1. Created Designed
    M Machoke
    Machoke
    Model
    Duration
    Tokens
    Cost
    Completed Jun 26, 22:38 · about 11 hours ago
    api
  2. Designed Building
    M Machoke
    Machoke
    Model
    claude-opus-4-8
    Duration
    about 2 hours
    Tokens
    83,227,721
    Cost
    ~$63.99
    Started Jun 26, 22:38
    Completed Jun 27, 01:07 · about 9 hours ago
    cli
  3. Building Submitted
    M Machoke
    Machoke
    Model
    claude-opus-4-8
    Duration
    33 minutes
    Tokens
    9,751,180
    Cost
    ~$6.61
    Started Jun 27, 01:07
    Completed Jun 27, 01:40 · about 8 hours ago
    cli
  4. Submitted Blocked
    Model
    Duration
    about 3 hours
    Tokens
    Cost
    Started Jun 27, 01:40
    Completed Jun 27, 04:29 · about 5 hours ago
    api
  5. Blocked Building
    M Machoke
    Machoke
    Model
    claude-opus-4-8
    Duration
    about 1 hour
    Tokens
    20,050,457
    Cost
    ~$27.34
    Started Jun 27, 04:29
    Completed Jun 27, 05:43 · about 4 hours ago
    cli
  6. Building Submitted
    M Machoke
    Machoke
    Model
    claude-opus-4-8
    Duration
    6 minutes
    Tokens
    4,693,078
    Cost
    ~$3.76
    Started Jun 27, 05:43
    Completed Jun 27, 05:49 · about 4 hours ago
    cli
  7. Submitted Reviewed
    S Shannon
    Shannon primary
    A Alex
    Alex light
    Model
    gpt-5.5
    Duration
    24 minutes
    Tokens
    Cost
    Started Jun 27, 05:49
    Completed Jun 27, 06:13 · about 4 hours ago
    cli
  8. Reviewed Assembled
    S Steffon
    Steffon
    Model
    gpt-5.5
    Duration
    21 minutes
    Tokens
    262,720
    Cost
    ~$0.53
    Started Jun 27, 06:13
    Completed Jun 27, 06:34 · about 3 hours ago
  9. Assembled Shipped
    A Avi
    Avi
    Model
    gpt-5.5
    Duration
    17 minutes
    Tokens
    1,158,969
    Cost
    ~$1.11
    Started Jun 27, 06:34
    Completed Jun 27, 06:52 · about 3 hours ago

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

QA Feedback codex about 5 hours ago

PR #255 needs rework: session-preflight fails because installed active qa-release skills in /Users/alex/.claude and /Users/alex/.codex are stale relative to docs/agents/skills/qa-release/SKILL.md, so agents would still load the old review flow. Run bin/install-agent-docs from the worktree and resubmit. Also clean up devops-cycle-design cold-start language that still says the conductor reviews, merges, and deploys work; it conflicts with the new primary-owned merge model.

Comment about 4 hours ago

QA approved PR #255 at c36e948. Preflight passed; active qa-release skill installs are synced; focused docs/SOP suite passed: 118 runs, 725 assertions, 0 failures; CI run 28280356139 green. No merge performed.

Sealed-bid sizing

Edit →

Alex (PM)

Avi (PO)

LARGE

Dev

LARGE

Actual

XL