Agents Builders

Reviewer-select builder exclusion

Archived carl
reviewer-select-exclude

Created

Jun 24, 17:56

Started

Jun 24, 17:57

Completed

Jun 24, 18:59

DevOps handoff

Type

Feature

Shape

backend

Worktree Slug

reviewer-select-exclude

Repositories

mcritchie-studio

Release Train

Branch

feat/reviewer-select-exclude

Local URL

QA URL

Production URL

devops review-routing

Acceptance Criteria

  • Moving a task to building records built_by agent
  • reviewer-select auto-excludes the recorded builder
  • reviewer-select can exclude a passed busy set
  • Docs cover built_by capture and busy exclusion

Expected Test Plan

  • [unit] built_by auto-stamp + busy exclusion + starve guard
  • [integration] reviewer-select CLI omits builder + busy

Checks Run

  • [review] Carl (heavy/backend) APPROVE + Jasper (light) APPROVE — reviewer_selector+task+CLI tests 132+8 runs 0 fail; builder-exclusion precedence sound, starve-guard tight (always >=2 candidates), seed byte-identical for no-busy path

Agent Context

Session retro improvement #3. Two routing misses this session: (a) reviewer-select picked carl to review the PR carl BUILT because task built_by was unset — I passed --builder carl by hand every time; (b) it assigned agents mid-build/mid-review on OTHER in-flight tasks (jasper while building geo; carl while reworking the conductor PR). FIX (a): when a task moves to 'building' via bin/task, stamp metadata.devops.built_by with the acting agent (the session/persona doing the build); reviewer-select (app/services/reviewer_selector.rb + bin/reviewer-select) should read task built_by and auto-exclude it by default (it already has a --builder OVERRIDE — make the recorded built_by the default source). FIX (b): give reviewer-select a --busy a,b,c flag (and/or have it query the board for agents currently on in-flight tasks: stage=building/claimed) and exclude them, but NEVER shrink the candidate pool below what's needed to pick a pair (keep-rather-than-starve, like the existing builder-keep logic). DOCS: devops-cycle-design.md reviewer-select section + the parallel-agent-devops module.

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. means the agent didn't report that metric.

  1. Created Designed
    D Drowzee
    Drowzee
    Model
    Duration
    Tokens
    Cost
    Completed Jun 24, 17:56 · 3 days ago
    api
  2. Designed Building
    D Drowzee
    Drowzee
    Model
    claude-opus-4-8
    Duration
    under a minute
    Tokens
    Cost
    Started Jun 24, 17:56
    Completed Jun 24, 17:57 · 3 days ago
    cli
  3. Building Submitted
    D Drowzee
    Drowzee
    Model
    claude-opus-4-8
    Duration
    44 minutes
    Tokens
    Cost
    Started Jun 24, 17:57
    Completed Jun 24, 18:41 · 3 days ago
    cli
  4. Submitted Reviewed
    C Carl
    Carl primary
    A Alex
    Alex light
    Model
    claude-opus-4-8
    Duration
    7 minutes
    Tokens
    Cost
    Started Jun 24, 18:41
    Completed Jun 24, 18:48 · 3 days ago
    cli
  5. Reviewed Assembled
    S Steffon
    Steffon
    Model
    Duration
    under a minute
    Tokens
    Cost
    Started Jun 24, 18:48
    Completed Jun 24, 18:49 · 3 days ago
  6. Assembled Shipped
    A Avi
    Avi
    Model
    Duration
    10 minutes
    Tokens
    Cost
    Started Jun 24, 18:49
    Completed Jun 24, 18:59 · 3 days ago
  7. Shipped Archived
    8
    81fad33e-98b5-4075-8ed6-d0efe6cb5804
    Model
    claude-opus-4-8
    Duration
    1 day
    Tokens
    Cost
    Started Jun 24, 18:59
    Completed Jun 25, 21:16 · 1 day ago
    cli

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

Comment avi 3 days ago

Review cascade (my session): steffon[heavy] APPROVE — built_by precedence correct (actor-soul>keep-existing>agent_slug, UUIDs rejected), busy exclusion sound (--busy + --busy-auto rescues SystemExit+StandardError), starve guard mathematically correct (never below MIN_CANDIDATES), seed reproducibility byte-for-byte (excluded_busy folds in only when non-empty). alex[light] APPROVE — docs accurate, no stale --builder-by-hand wording. 2/2 APPROVE, CI green, MERGEABLE. READY TO MERGE — no re-review needed. HELD per operator: parallel conductor (rel-20260624-6f6638) owns the merge/deploy lane.

Sealed-bid sizing

Edit →

Alex (PM)

Avi (PO)

Dev

Actual