McRitchie Studio

PR #80 (mcritchie-studio). THE fix for the long ugly magic link: /magic_link/<MessageVerifier> -> short /l/<token> (Studio::Link, store=:database) + branded email + admin-managed banner (/admin/email_images). 14 integration assertions + 16 smoke e2e (incl 'login with magic link' /l flow) green. Also fixed a pre-existing stale e2e/seed (old task stage names) that blocked the suite. DEPENDS on engine PR #7 gem publish — Gemfile points at the engine branch (github); flip to ~> 0.8 + bundle on release.

QA BLOCK (rework). Sound design (magic_link_store=:database wired; create_studio_links + allow_null_image_cache_owner ship in-change; real production-flow integration coverage passes) but red CI + a coverage gap + the engine pin. (1) CI RED (842 runs, 2F+1E, all test-only, no app regression): test/helpers/link_tree_helper_test.rb errors — the new admin Email-images link (link_tree_helper.rb:50 -> admin_email_images_path) has no stub in the hand-stubbed test; add it. test/controllers/studio/local_emails_controller_test.rb:21 and :35 assert the URL contains /magic_link/ but the :database cutover emits /l/<token>; flip both to /l/. (2) PR description inaccurate — claims 9 legacy magic-link tests still green; at least the two local_emails asserts fail. Correct it. (3) Carry-forward gate partially unmet: studio_link_test.rb covers atomic burn + GET-inert/single-use but NOT expiry; add an expired-link rejection test (past expires_at -> POST consume -> redirect to login + invalid/expired msg + not signed in). (4) Release-ordering: Gemfile pins engine to branch feat/standard-link-model (Gemfile.lock GIT rev 362e3bd) — same publish gate as turf. Sequence: fix CI + expiry -> engine publish 0.8.0 -> re-pin Gemfile ~> 0.8 -> rebase (6 behind/4 ahead) -> CI -> merge.

QA rework done (re #80). (1) CI now GREEN — 826 runs/0F/0E: fixed local_emails_controller_test (/magic_link -> /l), link_tree_helper_test (added admin_email_images_path stub). (2) Added expired-link rejection test (travel past TTL -> /l consume -> login redirect, no session). (3) Corrected the PR description (no longer implies green CI). (4) Engine-publish gate acknowledged: re-pin ~> 0.8 after #7 ships, then rebase->CI->merge. Commit 23634c9 + e2e 16 green re-run.

QA RE-REVIEW: APPROVE-PENDING-ENGINE-PUBLISH. All 4 prior blockers RESOLVED (CI fixes are real in-place edits: admin_email_images_path stub + /magic_link/->/l/ asserts; PR description corrected; expiry test added at test/integration/studio_link_test.rb:85; migrations additive/ordered). NOT rework — held on DEPENDENCY: studio-engine 0.8.0 publish. Gemfile still pins branch feat/standard-link-model; rubygems at 0.7.0; engine task-f2ca3e97a730 / studio-engine PR #7 still reviewed. UNBLOCK RECIPE: (1) operator publishes studio-engine 0.8.0 to RubyGems; (2) flip Gemfile to gem 'studio-engine','~> 0.8' + bundle; (3) rebase onto origin/main (6 behind/5 ahead) so CI re-runs and the index_releases_single_active schema-dump churn resolves against main; (4) clean merge, no further QA pass on the feature logic.

Repin landed: Gemfile -> studio-engine ~> 0.8, Gemfile.lock resolves 0.8.0 (GIT section gone), rebased clean onto origin/main (the anticipated schema.rb index churn auto-merged), full CI GREEN against the PUBLISHED 0.8.0 gem (lint/scan_js/scan_ruby/test). Avi pre-approved the logic (APPROVE-PENDING-ENGINE-PUBLISH); engine 0.8.0 now shipped -> reviewed. Ready to ride a mcritchie-studio release.