McRitchie Studio

Senior review -> APPROVED (2/2). Reviewers: Carl (backend/safety heavy) + Alex (SOP-accuracy light), both high confidence. 120 tests / 691 assertions green; all 6 acceptance met. SAFETY CONFIRMED: dev deploy toolbar is Rails.env.local?-gated (403 in prod, tested) and every mutation scoped to the dev_fixture marker -- never touches a real Release/board. Overlap with #249 (already in RC) on _release_summary.html.erb is CLEAN (#250 restyles bottom tracker dots; #249 header seal badge byte-identical). Infographic faithfully represents the documented model (owners/gates/one-operator-gate/pulses/stage names match sections 1.2/1.4; the 2 real divergences honestly flagged with a warning). Follow-ups (non-blocking): (1) MAJOR clarity (Alex) -- scannable tile labels reuse across lanes mislabel distinct gates: 'Visual' appears nowhere in the model; 'QA Acceptance' mislabels Avi's frozen-SHA e2e gate; 'PR Review'/'Merge Review' reused. One-file YAML rename recommended (expand panels accurate, so non-blocking but undercuts an understanding artifact). (2) docs not cross-referenced though the YAML header claims they are -- add a section-1.4 pointer. (3) designed/blocked/archived stages absent -- add a 'happy path' caption. (4) minor: stale comment tasks_controller.rb:43; hardcoded legend order. -> reviewed.

Senior review -> APPROVED (2/2) for PR #16 (the 3-task rolio-demo bundle). Reviewers: Steffon (backend heavy) + Shannon (UI light), both high confidence. Backend verified end-to-end with ANTHROPIC_API_KEY UNSET: db:migrate + seed + warm rake + 70+52 tests green, deterministic (identical payload SHA across reseeds), idempotent; one shared EnrichmentService; migrations additive/reversible. UI demo-ready (admin group-by-kind + counts, socials handles, editable cadence with no-JS fallback, Fathom taxonomy). SHIP HAZARD (Steffon, major): GitHub PR #16 = origin/feat/rolio-demo at 137c1ca (43 files, REVIEWED). The LOCAL feat/rolio-demo is 2 commits AHEAD (a88fc48 + 5df4214) -- an un-reviewed Wave-2 Event Hub stacked on the SAME branch, on NO remote. Merge PR #16 from origin at 137c1ca ONLY; do NOT push the local feat/rolio-demo branch (would balloon #16 from 43 to 57 files with un-reviewed code). Move Wave 2 onto its own branch and PUSH it (currently unpushed = loss risk). Non-blocking polish: ai_cache.rb fetch TOCTOU (rescue RecordNotUnique / upsert); 20s post-import sync spinner -> shorten to ~5-8s for stage; seeds.rb header reword; admin find-by-PK vs public_id. -> reviewed.

Senior review -> APPROVED (2/2) for PR #16 (the 3-task rolio-demo bundle). Reviewers: Steffon (backend heavy) + Shannon (UI light), both high confidence. Backend verified end-to-end with ANTHROPIC_API_KEY UNSET: db:migrate + seed + warm rake + 70+52 tests green, deterministic (identical payload SHA across reseeds), idempotent; one shared EnrichmentService; migrations additive/reversible. UI demo-ready (admin group-by-kind + counts, socials handles, editable cadence with no-JS fallback, Fathom taxonomy). SHIP HAZARD (Steffon, major): GitHub PR #16 = origin/feat/rolio-demo at 137c1ca (43 files, REVIEWED). The LOCAL feat/rolio-demo is 2 commits AHEAD (a88fc48 + 5df4214) -- an un-reviewed Wave-2 Event Hub stacked on the SAME branch, on NO remote. Merge PR #16 from origin at 137c1ca ONLY; do NOT push the local feat/rolio-demo branch (would balloon #16 from 43 to 57 files with un-reviewed code). Move Wave 2 onto its own branch and PUSH it (currently unpushed = loss risk). Non-blocking polish: ai_cache.rb fetch TOCTOU (rescue RecordNotUnique / upsert); 20s post-import sync spinner -> shorten to ~5-8s for stage; seeds.rb header reword; admin find-by-PK vs public_id. -> reviewed.

Senior review -> APPROVED (2/2) for PR #16 (the 3-task rolio-demo bundle). Reviewers: Steffon (backend heavy) + Shannon (UI light), both high confidence. Backend verified end-to-end with ANTHROPIC_API_KEY UNSET: db:migrate + seed + warm rake + 70+52 tests green, deterministic (identical payload SHA across reseeds), idempotent; one shared EnrichmentService; migrations additive/reversible. UI demo-ready (admin group-by-kind + counts, socials handles, editable cadence with no-JS fallback, Fathom taxonomy). SHIP HAZARD (Steffon, major): GitHub PR #16 = origin/feat/rolio-demo at 137c1ca (43 files, REVIEWED). The LOCAL feat/rolio-demo is 2 commits AHEAD (a88fc48 + 5df4214) -- an un-reviewed Wave-2 Event Hub stacked on the SAME branch, on NO remote. Merge PR #16 from origin at 137c1ca ONLY; do NOT push the local feat/rolio-demo branch (would balloon #16 from 43 to 57 files with un-reviewed code). Move Wave 2 onto its own branch and PUSH it (currently unpushed = loss risk). Non-blocking polish: ai_cache.rb fetch TOCTOU (rescue RecordNotUnique / upsert); 20s post-import sync spinner -> shorten to ~5-8s for stage; seeds.rb header reword; admin find-by-PK vs public_id. -> reviewed.

Senior review -> APPROVED (2/2). Reviewers: Carl (backend/migration heavy) + Alex (release-semantics/docs light), both high confidence. Confirmed the EXISTING SHIP FLOW IS SAFE: seal is a post-/up-gate step 5c, read-only against prod, strictly NON-BLOCKING (no new abort/rollback path; board write rescued); migration purely additive (jsonb, schema matches, no backfill); 149 focused tests green. Follow-ups (non-blocking): (1) minor bin/release line ~1474 -- the bin/prod-smoke spawn (Open3) sits OUTSIDE the degrade-to-warn rescue; a narrow env failure (non-exec / wrong CWD) could propagate between deploy and ship!/notes, leaving a release stuck assembled with no notes -- wrap the sh call; (2) medium: docs devops-cycle-design section 1.4 Run Deployment prose not updated for the new seal/badge step (AGENTS.md docs-in-same-pass); add ~2 sentences; (3) low: devops_test_suites.yml production_url comment overstates its role (host actually resolves from release_repos smoke_url). -> reviewed.

Senior re-review -> APPROVED (2/2). Reviewers: Shannon (UI heavy) + Carl (model/tests light), both high confidence. Re-review after the pulse/ticking-duration commits: all 230 tests green; all 9 acceptance criteria met (incl. pill removed, live ticker, pulsing bg, hides arrow/next, active-stage verb form). Live ticker verified as a correct Alpine x-data factory; Nokogiri-static assertions respected. Non-blocking follow-ups: (1) this PR orphaned the components/elapsed_label_script include at _consolidated_timeline.html.erb:58 -> now injects an unused window.elapsedLabel global; drop line 58 (keep it on _board.html.erb:43); (2) stale header doc lines 19-21 contradict the new code; update in same pass; (3) nits: motion-safe:animate-pulse, and a percent sign inside an ERB comment body. -> reviewed.

Closed out via rolio's own (non-pipeline) path: rolio is not a bin/release member (not in release_repos.yml; no bin/deploy/heroku remote here), so it could not ride rel-20260626-6d5d0e. Approved PR #15 merged into rolio main (2026-06-26T21:34Z). App deploy, if any, happens in rolio's own environment.

Senior review → APPROVED (2/2). Reviewers: Shannon (UI) + Carl (rails/integration), both high confidence. All 10 integration tests green (47 assertions). Acceptance: all 4 met — single CSS-only aurora painted at .phone level via content_for :phone_bg behind hero (z-index 0 vs hero 1); contained by .phone overflow:hidden+radius and .splash-phonebg overflow:hidden (absorbs -25% layer bleed); reduced-motion fallback present (@media prefers-reduced-motion → animation:none, radial-gradient fills remain); hero readable (near-black headline + filled CTA above aurora, bottom mask keeps home band white). Perf: gradient-softness not blur, only transform animated (GPU-composited). Non-blocking follow-ups: (1) reduced-motion fallback not test-guarded — add assert_match(/prefers-reduced-motion/, response.body); (2) subtitle copy 'enriched searchable contacts' missing comma; (3) subtitle --label-2 ~2:1 worst-case over central blob — optional scrim/contrast nudge, on-device glance.

Senior review → APPROVED (2/2). Reviewers: Shannon (UI) + Carl (test), both high confidence. All 65 tests green (341 assertions). Acceptance: all 4 met — transition row justify-center (ml-auto dropped from both in-progress + reconstructed chips), crew avatar-over-name (flex-col items-center text-center), review pair → grid grid-cols-2 two equal columns, single actor → justify-center flex. Component test pins STATIC ERB classes (not Alpine-managed — Nokogiri gotcha N/A) and exercises both pair (reviewed block) and single (assembled block) branches via deploy-crew seed. No findings.

Senior review → APPROVED (2/2). Reviewers: Steffon (devops/tooling) + Carl (rails/tests), both high confidence. Tests green: command suite (7 tests/92 assertions) + controller show/latest (4/16) + 30 focused all pass. Acceptance: all 6 met — latest-feedback now sourced from real latest_activity serializer with /api/v1/activities fallback (prior HEAVY block resolved); branch-drift, PR/checks, overlap, docs-drift, stale-terms, test-tiers all covered by deterministic command tests. Non-blocking follow-ups (do NOT gate ship): (1) overlap_report issues one gh-pr-view per candidate across up to 30 PRs serially — cap merged depth or drop merged sweep; (2) latest_activity_json orders by created_at only — add id tiebreaker for guaranteed determinism; (3) dead task.dig('devops','task_url') falls through harmlessly.

PR #243 is ready for Avi QA. Build board now subscribes to live task broadcasts; /tasks updates building-to-blocked cards without reload. Local review: http://localhost:3024/tasks. Verification recorded in checks_run, including full-suite/rubocop fingerprint ed17e0c615ca.

Revision applied: removed checkmark emoji from completed Next Release tracker labels while keeping past-tense labels and the active pulse. PR #241 now ends at be99795. Verified focused helper/controller/broadcaster tests, targeted RuboCop, Playwright no-emoji smoke, full-suite-check, and DoR.

Implemented Next Release tracker labels with active/complete wording: Testing/Tested, Assembling/Assembled, Deploying/Live on QA, Testing/Confirmed, Deploying/Deployed. Added active connector pulse and component coverage. Verified with helper/controller/broadcaster tests, full-suite-check, DoR, and local Playwright desktop/mobile smoke at http://localhost:3023/deployments.

REBASE DONE (pre-handoff): feat/document-stage-event-trail rebased onto origin/release (3d8708a->c6ca176, force-with-lease). Clean — zero conflicts (the paper-trail blockquote lands in the Build-SOP region, untouched by the wire PR's §1.2/§1.4 rewrite). Verified the rebased devops-cycle-design.md carries BOTH #117's content AND the shipped alex-docs/reviewer-select cascade. Now 1 commit ahead of release, mergeable. Still at submitted for the fresh-session 2-senior review.

Already delivered out-of-band: fix shipped inline during dogfooding as commit 66db6f2 (2026-06-22), an ancestor of origin/main (LIVE on prod). All 4 acceptance criteria covered by test/lib/dor_check_test.rb (32 runs, 224 assertions, 0 failures): release-aware default_diff_base (origin/release, fallback origin/main), release-cut docs branch not false-flagged, fallback test, and the with_release_ahead_repo regression + e2e gate. No dedicated PR — fix predates this task record. Moved to shipped to reflect reality.

#40 rebased onto origin/main (behind 0) and adopted a stack env (redis db 23). qa-intake cleared the needs-agent flags; now checks-review pending CI on the new push. Doc corrections moved to follow-up PR #43 since #34 already merged.

#39 rebased onto origin/main (behind 0) and adopted a proper bin/agent-worktree stack env (port 3016, redis db 22). qa-intake now labels it avi-ready. Ready for review again.

Post-deploy production smoke passed on https://www.mcritchie.studio. Signed in through the normal magic-link flow as the McRitchie admin user and verified sidebar Back behavior across /dashboard, /tasks, /tasks/task-ea8541e4b5b6, and /agents for gear, username, and avatar triggers. All 12 route/trigger cases reopened the sidebar after Back and closed with Escape. No remaining closeout blocker from the feature agent side.

Addressed: PR #34 updates task-board-api.md to the new comma contract (array input preserves commas; string/UI free-text still splits). Added API controller coverage (commit 9af41e2) for a comma inside a JSON acceptance item -> stored as one. Re-requesting review.

Addressed (commit 4bbc91a): bin/task agent_secret now checks File.executable?(op) and rescues SystemCallError, so a host without the 1Password CLI falls through to the .env fallback instead of crashing. The docs pointing agents at bin/task/bin/secret as the primary path landed in PR #34 (task-board-api.md). Re-requesting review.