McRitchie Studio

Agent Context

Found by dogfooding: the docs task document-agent-shell-test-gotchas, cut from origin/release, was false-flagged by the chore-gate as 'ships a code diff (application_helper.rb, formatter.rb, _overflow_fade.html.erb, …)' — files committed on release-but-not-main, NOT the branch's own change (which is only docs/agents/modules/testing.md). Root cause: bin/dor-check changed_files' committed view runs 'git diff --name-only $DOR_CHECK_DIFF_BASE...HEAD' with base defaulting to origin/main; on the persistent-release model feature branches are cut from origin/release (ahead of main), so origin/main...HEAD includes the whole release delta. The working-tree views (--cached / --name-only / ls-files --others) are correct; only the committed view is polluted. Fix: default the base to origin/release (the branch's actual cut point), falling back to origin/main when origin/release doesn't exist (mirror bin/agent-worktree's base resolution). Verified: 'DOR_CHECK_DIFF_BASE=origin/release bin/dor-check' returns 'DoR n/a' for the doc task. Bug SOP: write the failing regression test FIRST (a release-ahead-of-main doc/chore branch must be n/a, not gated). This false-flags every doc/chore task cut from release; harmless for code tasks (they carry a shape anyway).